429 files

custom_components/spook/ectoplasms/script/repairs/unknown_label_references.py

@@ -2,16 +2,20 @@
 
 from __future__ import annotations
 
+from typing import TYPE_CHECKING
+
 from homeassistant.components import script
 from homeassistant.helpers import label_registry as lr
-from homeassistant.helpers.entity_component import DATA_INSTANCES, EntityComponent
 
-from ....const import LOGGER
 from ....entity_filtering import async_filter_known_label_ids, async_get_all_label_ids
-from ....repairs import AbstractSpookRepair
+from ....reference_extraction import extract_targets_from_config
+from ....repairs import AbstractSpookEntityComponentUnknownReferencesRepair
+
+if TYPE_CHECKING:
+    from typing import Any
 
 
-class SpookRepair(AbstractSpookRepair):
+class SpookRepair(AbstractSpookEntityComponentUnknownReferencesRepair):
     """Spook repair tries to find unknown referenced labels in scripts."""
 
     domain = script.DOMAIN
@@ -19,43 +23,28 @@ class SpookRepair(AbstractSpookRepair):
     inspect_events = {lr.EVENT_LABEL_REGISTRY_UPDATED}
     inspect_on_reload = True
 
-    automatically_clean_up_issues = True
+    unavailable_entity_class = script.UnavailableScriptEntity
+    entity_label = "script"
+    reference_label = "labels"
+    edit_url_pattern = "/config/script/edit/{unique_id}"
 
-    async def async_inspect(self) -> None:
-        """Trigger a inspection."""
-        if self.domain not in self.hass.data[DATA_INSTANCES]:
-            return
+    _known_label_ids: set[str]
 
-        entity_component: EntityComponent[script.ScriptEntity] = self.hass.data[
-            DATA_INSTANCES
-        ][self.domain]
+    async def _async_setup_inspection(self) -> None:
+        """Cache known label IDs for this inspection cycle."""
+        self._known_label_ids = async_get_all_label_ids(self.hass)
 
-        known_label_ids = async_get_all_label_ids(self.hass)
+    async def _async_compute_unknown_references(self, entity: Any) -> set[str]:
+        """Return unknown label IDs referenced by ``entity``."""
+        label_ids = set(entity.script.referenced_labels)
 
-        LOGGER.debug("Spook is inspecting: %s", self.repair)
-        for entity in entity_component.entities:
-            self.possible_issue_ids.add(entity.entity_id)
-            if not isinstance(entity, script.UnavailableScriptEntity) and (
-                unknown_labels := async_filter_known_label_ids(
-                    self.hass,
-                    label_ids=entity.script.referenced_labels,
-                    known_label_ids=known_label_ids,
-                )
-            ):
-                self.async_create_issue(
-                    issue_id=entity.entity_id,
-                    translation_placeholders={
-                        "labels": "\n".join(f"- `{label}`" for label in unknown_labels),
-                        "script": entity.name,
-                        "edit": f"/config/script/edit/{entity.unique_id}",
-                        "entity_id": entity.entity_id,
-                    },
-                )
-                LOGGER.debug(
-                    (
-                        "Spook found unknown labels in %s "
-                        "and created an issue for it; Labels: %s",
-                    ),
-                    entity.entity_id,
-                    ", ".join(unknown_labels),
-                )
+        # Also walk the raw configuration; the built-in extraction misses
+        # references nested in some step types, like repeat sequences.
+        if raw_config := getattr(entity, "raw_config", None):
+            label_ids.update(extract_targets_from_config(raw_config).label_ids)
+
+        return async_filter_known_label_ids(
+            self.hass,
+            label_ids=label_ids,
+            known_label_ids=self._known_label_ids,
+        )